Skip to content

DS-63 using WSL doesn't need to run the admin windows service#16586

Merged
aevesdocker merged 1 commit intodocker:mainfrom
elapuyade:DS-63-win-update-win-root-permission-requirements-docs
Feb 27, 2023
Merged

DS-63 using WSL doesn't need to run the admin windows service#16586
aevesdocker merged 1 commit intodocker:mainfrom
elapuyade:DS-63-win-update-win-root-permission-requirements-docs

Conversation

@elapuyade
Copy link
Contributor

Proposed changes

https://docker.atlassian.net/browse/DS-69 and https://docker.atlassian.net/browse/DS-70 change the requirement to run the windows service when using WSL2.

This PR updates the documentation according to that.

Related issues (optional)

https://docker.atlassian.net/browse/DS-63

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e819b1a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63d00b0b93340a00080e3baa
😎 Deploy Preview https://deploy-preview-16586--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elapuyade LGTM

Do you want this published today, or does it coincide with Docker Desktop 4.17 release?

@elapuyade
Copy link
Contributor Author

The corresponding code changes should be integrated for 4.17. I'll merge this here when I'm sure the code goes into 4.17 as well.

@aevesdocker aevesdocker added this to the DD4.17 milestone Jan 25, 2023
@aevesdocker aevesdocker merged commit 730e33f into docker:main Feb 27, 2023
@elapuyade
Copy link
Contributor Author

Hi Allie, I just saw you merged this. The code change has finally not made it to 4.17, it will be in 4.18.

Is this merged for 4.17?

@aevesdocker
Copy link
Contributor

Hi @elapuyade, ah, thanks for letting me know. It hasn't made it into production yet, so I've just reverted the merge.

@elapuyade
Copy link
Contributor Author

/merge

@elapuyade
Copy link
Contributor Author

The corresponding code is now merged in pinata main.

@aevesdocker
Copy link
Contributor

Thanks @elapuyade. I need to wait until the DD 4.18 release day to merge this into docs. The new PR is here with the DD4.18 milestone attached

#16799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants