Fix docker compose ps to honor psFormat setting in .docker/config.json#13645
Open
maks2134 wants to merge 1 commit intodocker:mainfrom
Open
Fix docker compose ps to honor psFormat setting in .docker/config.json#13645maks2134 wants to merge 1 commit intodocker:mainfrom
maks2134 wants to merge 1 commit intodocker:mainfrom
Conversation
- Change format flag default from "table" to empty string to allow config override - Add logic to use PsFormat from config when no format argument provided - Fall back to "table" format when neither PsFormat nor format arg is set - Add warning when both --format and --quiet flags are used - Add test to verify format flag default value Fixes docker#13643 Signed-off-by: maks2134 <maks210306@yandex.by>
glours
requested changes
Mar 23, 2026
Contributor
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
Thanks for the contribution 🙏
This one need some changes to properly and transparently support psFormat setting
Can you also add more tests regarding the comment I made when changing or not the --format flag please?
Comment on lines
+158
to
+162
| if len(opts.Format) == 0 { | ||
| opts.Format = "table" | ||
| } else if opts.Quiet { | ||
| _, _ = dockerCli.Err().Write([]byte("WARNING: Ignoring custom format, because both --format and --quiet are set.\n")) | ||
| } |
Contributor
There was a problem hiding this comment.
With this changes users with psFormat in their config who runs docker compose ps -q would get a spurious warning.
We should only trigger this check when cmd.Flags().Changed("format") is true
Contributor
There was a problem hiding this comment.
Also I would prefer we use fmt.Fprintln instead of Write like this
fmt.Fprintln(dockerCli.Err(), "WARNING: ...")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13643
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did