Add sub_provider field to User model and UI#1174
Closed
Copilot wants to merge 1 commit intofeature/make-subprovider-configerable-uifrom
Closed
Add sub_provider field to User model and UI#1174Copilot wants to merge 1 commit intofeature/make-subprovider-configerable-uifrom
Copilot wants to merge 1 commit intofeature/make-subprovider-configerable-uifrom
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Copilot
AI
changed the title
[WIP] Add the sub provider field to UI
Add sub_provider field to User model and UI
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues and adds a database migration to resolve schema inconsistency:
Zatladder Controller: When no Amber users exist, fallback to sofia_account users instead of crashing:
users = User.in_amber.any? ? User.in_amber : User.sofia_account
@users_spendings = users.calculate_spendings(from:, to:)
OTP Authentication: Accept 1-period drift to handle clock skew between client and server:
sofia_account.authenticate_otp(params[:verification_code], drift: 1)
Database Migration: Adds order_total column back to orders table if missing, resolving schema.rb inconsistency.
Other information
Migration is idempotent using column_exists? check to safely run on environments where the column may already exist.