Skip to content

Add defensive check for http2 sessions#783

Merged
srikrsna-buf merged 2 commits intomainfrom
sk/fix-session-race
Aug 24, 2023
Merged

Add defensive check for http2 sessions#783
srikrsna-buf merged 2 commits intomainfrom
sk/fix-session-race

Conversation

@srikrsna-buf
Copy link
Copy Markdown
Member

Add defensive check for http2 sessions. This should fix #683. The solution is similar to the one by @mustard-mh in #712 it checks if the session is destroyed/closed and moves to closed state and retries the request with a new connection.

@srikrsna-buf srikrsna-buf requested a review from timostamm August 24, 2023 04:32
Copy link
Copy Markdown
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srikrsna-buf srikrsna-buf merged commit 6b431cc into main Aug 24, 2023
@srikrsna-buf srikrsna-buf deleted the sk/fix-session-race branch August 24, 2023 12:19
@htranugaming
Copy link
Copy Markdown

@srikrsna-buf can you pump a version for this commit?, I still got this issue on my production site, thanks you

@smaye81 smaye81 mentioned this pull request Aug 29, 2023
@timostamm
Copy link
Copy Markdown
Member

@htranugaming, this just shipped in v0.13.2. Let us know if this fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[internal] The session has been destroyed

3 participants