Call throw and return on response iterables in the node adaptor#775
Merged
srikrsna-buf merged 4 commits intomainfrom Aug 24, 2023
Merged
Call throw and return on response iterables in the node adaptor#775srikrsna-buf merged 4 commits intomainfrom
throw and return on response iterables in the node adaptor#775srikrsna-buf merged 4 commits intomainfrom
Conversation
srikrsna-buf
commented
Aug 18, 2023
| ); | ||
| isWriteError = false; | ||
| for (; !chunk.done; chunk = await it.next()) { | ||
| isWriteError = true; |
Member
Author
There was a problem hiding this comment.
Could do it by using a local try catch but this seemed clearer. I didn't want to rely on node semantics of having a code property.
srikrsna-buf
changed the title
throw and return on handlerthrow and return on response iterables
srikrsna-buf
changed the title
throw and return on response iterablesthrow and return on response iterables
srikrsna-buf
changed the title
throw and return on response iterablesthrow and return on response iterables in the node adaptor
srikrsna-buf
changed the title
throw and return on response iterables in the node adaptorthrow and return on response iterables in the node adaptor
timostamm
approved these changes
Aug 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
throwandreturnon response iterables in the node adaptor. This along with #751 ensures that write errors are propagated back to the handler ensuring any cleanup code is run in the handlers.