Fix memory leak in Http2SessionManager's verify step#1616
Merged
timostamm merged 12 commits intoconnectrpc:mainfrom Nov 17, 2025
Merged
Fix memory leak in Http2SessionManager's verify step#1616timostamm merged 12 commits intoconnectrpc:mainfrom
timostamm merged 12 commits intoconnectrpc:mainfrom
Conversation
Signed-off-by: ttyniwa <noencrypt@gmail.com>
Contributor
Author
|
@timostamm Thank you for your review. |
timostamm
reviewed
Nov 14, 2025
Member
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
Nice. Let's get this merged. But there are two issue to fix before we can merge this:
- The code isn't formatted correctly. You can run
npm run format --workspace packages/connect-nodeto fix that. - You'll have to sign your commits. See the DCO check for more information on how to sign.
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Timo Stamm <ts@timostamm.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Timo Stamm <ts@timostamm.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: ttyniwa <noencrypt@gmail.com>
Signed-off-by: ttyniwa <noencrypt@gmail.com>
ttyniwa
force-pushed
the
feature/fix-memory-leak-in-http2sessionmanager
branch
from
471b0d4 to
7a10a4c
Compare
Signed-off-by: ttyniwa <noencrypt@gmail.com>
Contributor
Author
|
Thanks for your support. Fixed it. |
timostamm
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Within the verify function of Http2SessionManager, error event listeners were not being unregistered upon success, resulting in a leak.
The following error log was observed:
(node:1)MaxListenersExceededWarning: Possible Event Emitter memory leak detected. 11 error listeners added to [ClientHttp2Session]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
Summary
Fixed a bug causing MaxListenersExceededWarning in Http2SessionManager.