Conversation
…en streams Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
changed the title
srikrsna-buf
approved these changes
Aug 28, 2025
timostamm
deleted the
tstamm/Don't-hold-on-to-HTTP/2-connections-after-receiving-GOAWAY-without-open-streams
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a HTTP/2 client receives a GOAWAY frame, it must not open new streams on the connection. Existing streams can finish, but new streams must use a new connection.
The
Http2SessionManagerfrom@connectrpc/connect-nodeimplements this logic. It automatically opens a new connection for new requests, and holds on to the current current, waiting for existing streams to finish. The new connection can also receive a GOAWAY frame, so all such connections are kept in a list of connections that are "shutting down".So far, so good. But if a connection without any open streams receives a GOAWAY frame, it's also put into the list of shutting down connections, and it's never vacated. This PR changes the behavior for connections without open streams: If they receive a GOAWAY frame, they are not added to the list of shutting down connections.
Fixes #1545.