Special case TimeoutError in ConnectError.from#1526
Merged
Conversation
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
srikrsna-buf
approved these changes
Jul 7, 2025
timostamm
deleted the
tstamm/Special-case-TimeoutError-in-ConnectError.from
branch
This was referenced Jul 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To abort an RPC, you pass an AbortSignal in the call options.
Usually, this is done by creating an AbortController, passing the controller's signal to the call options, and calling AbortController.abort() when necessary. The raised AbortError is automatically converted to the Connect error code
canceled.Alternatively it is also possible to create an AbortSignal via AbortSignal.timeout(). The signal will automatically abort after a specified time, with a TimeoutError. This error is currently converted to the Connect error code
unknown, but it should be codecanceled, same as with an AbortController.This PR updates the behavior, closing #1453.
Note that it is not recommended to use AbortSignal.timeout() with RPCs, because the timeout cannot be propagated to the server. Instead, use the
timeoutMsoption (documentation).