V2: Replace MethodInfo with Descriptor Types#1255
Merged
srikrsna-buf merged 2 commits intov2from Oct 3, 2024
Merged
Conversation
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
reviewed
Oct 3, 2024
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
approved these changes
Oct 3, 2024
Member
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
LGTM!
What do you think about calling this change "Replace MethodInfo with Descriptor Types"? Would probably provide a bit more context for users reading through the changelog.
srikrsna-buf
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace MethodInfo with Descriptor Types. We plan on adding these types to
@bufbuild/protobuf. We can remove the types once that is done.This also makes the types stricter, transport will now only accept unary descriptors for
unaryand streaming descriptors forstreammethods. Likewise the interceptor types are also stricter.