Merged
Conversation
Collaborator
Author
|
@vgvassilev This PR is ready for review. I don't know where it specifically addresses what you wanted in the issue, but I have tried to remove repetition in the ci. |
Contributor
|
Nice! Any chance to incorporate the wasm build? It seems quite different... |
Collaborator
Author
It may be possible, but I'd advise against it. I think the ci is clearer with the wasm and non wasm builds separate. |
Contributor
Ok, makes sense. Let's get this one in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplication within the ci
Fixes #42