Bring silk src into silk-release#89
Merged
winkingturtle-vmw merged 1 commit intodevelopfrom Aug 3, 2023
Merged
Conversation
reneighbor
added a commit
to cloudfoundry/silk
that referenced
this pull request
Aug 2, 2023
This repo is being merged into silk-release. See the following: - #52 - cloudfoundry/silk-release#89 [#185149418](https://www.pivotaltracker.com/story/show/185149418) Signed-off-by: Josh Russett <jrussett@vmware.com>
jrussett
changed the title
silk src into silk-releasesilk src into silk-release
We had originally setup silk in an enitre other repo with the intention that it could be imported, used, and extended by other projects. This never happened and now we have a separate repo for `silk` when it is only used in `silk-release. This commit takes [code.cloudfoundry.org/silk at commit 8e48b8d1e6812ccd3da7c93fb30728ad1d9000ed](cloudfoundry/silk@8e48b8d), and folds it into `silk-release` under `src/code.cloudfoundry.org/silk`. Other changes worth mentioning: - `scripts/test.sh` and `scripts/start-db-helper` taken from `cf-networking`, e.g. https://github.com/cloudfoundry/cf-networking-release/blob/develop/scripts/test.sh - the `silk` tests now require some databases to run - removes scripts from the `silk` source repo - Updates bosh packaging specs for the new pakage import path - Consolidates `modules/modules.go` and `tools/tools.go` since they seem to do the same thing and we don't need to import the silk stuff Addresses: cloudfoundry/silk#52 [#185149418](https://www.pivotaltracker.com/story/show/185149418) Signed-off-by: Renee Chu <reneec@vmware.com>
jrussett
force-pushed
the
consolidate-silk-into-silk-release-185149418
branch
from
0affaef to
96abf2b
Compare
winkingturtle-vmw
pushed a commit
to cloudfoundry/silk
that referenced
this pull request
Aug 3, 2023
This repo is being merged into silk-release. See the following: - #52 - cloudfoundry/silk-release#89 [#185149418](https://www.pivotaltracker.com/story/show/185149418) Signed-off-by: Josh Russett <jrussett@vmware.com> Co-authored-by: Renee Chu <reneec@vmware.com>
jrussett
added a commit
to jrussett/community
that referenced
this pull request
Aug 4, 2023
We had originally setup silk in an enitre other repo with the intention that it could be imported, used, and extended by other projects. This never happened and now we have a separate repo for `silk` when it is only used in `silk-release. We have moved `silk` into `silk-release` and therefore `silk` is no longer necessary. More details: - cloudfoundry/silk#52 - cloudfoundry/silk-release#89 [#185149418](https://www.pivotaltracker.com/story/show/185149418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had originally setup silk in an enitre other repo with the intention that it could be imported, used, and extended by other projects. This never happened and now we have a separate repo for
silkwhen it is only used in `silk-release.This commit takes code.cloudfoundry.org/silk at commit 8e48b8d1e6812ccd3da7c93fb30728ad1d9000ed, and folds it into
silk-releaseundersrc/code.cloudfoundry.org/silk.Other changes worth mentioning:
scripts/test.shandscripts/start-db-helpertaken fromcf-networking, e.g. https://github.com/cloudfoundry/cf-networking-release/blob/develop/scripts/test.sh - thesilktests now require some databases to runsilksource repomodules/modules.goandtools/tools.gosince they seem to do the same thing and we don't need to import the silk stuffAddresses: cloudfoundry/silk#52
#185149418