[jsg] declarative installation of js bundles#930
Merged
Conversation
mikea
changed the title
mikea
force-pushed
the
maizatskyi/2023-07-27-jsg-js-bundle
branch
from
00f1ee8 to
25bdc08
Compare
Defines JSG_CONTEXT_JS_BUNDLE to install a group of modules to context's module manager on creation. As other JSG_ declarations, this one can be conditional on current flags. Testing will be a primary use-case for this macro, but global worker context will see a usage once I go after replacing UrlPattern with js implementation.
mikea
force-pushed
the
maizatskyi/2023-07-27-jsg-js-bundle
branch
from
25bdc08 to
f80dfe5
Compare
jasnell
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines JSG_CONTEXT_JS_BUNDLE to install a group of modules to context's module manager on creation.
As other JSG_ declarations, this one can be conditional on current flags.
Testing will be a primary use-case for this macro, but global worker context will see a usage once I go after replacing UrlPattern with js implementation.