[jsg] replace internal module bundle flag with module type#915
Merged
Conversation
This will make adding new module types easier.
mikea
commented
Jul 25, 2023
| type @1 :Modules.ModuleType; | ||
| # if anyone ever needs module type, it can be implemented by either fixing the Modules reference | ||
| # problem above or copying the original enum. | ||
| # type @1 :Modules.ModuleType; |
Contributor
Author
There was a problem hiding this comment.
as of now it is not used anywhere so I wanted to stop banging my head on this.
jasnell
reviewed
Jul 25, 2023
jasnell
approved these changes
Jul 25, 2023
…yi/2023-07-25-module-type
Contributor
Author
|
double checking with @mrbbot that module.internal in rtti is not used by anyone. |
Contributor
|
Yep, not used anywhere yet. We can probably get away with not using it too. 👍 |
mrbbot
approved these changes
Jul 26, 2023
…2023-07-25-module-type
Contributor
Author
|
FYI I have verified that this doesn't break downstream build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make adding new module types easier.