Implement node crypto HKDF, except for KeyObject inputs#865
Merged
Conversation
jasnell
approved these changes
Jul 16, 2023
vickykont
reviewed
Jul 17, 2023
src/node/crypto.ts
Outdated
| createHash, | ||
| createHmac, | ||
| getHashes, | ||
| // Hkdf |
Contributor
There was a problem hiding this comment.
Nit; Indentation seems a little odd here.
Contributor
Author
There was a problem hiding this comment.
Nice catch, thank you
vickykont
reviewed
Jul 17, 2023
src/node/internal/crypto_hkdf.ts
Outdated
| @@ -0,0 +1,153 @@ | |||
| // Copyright (c) 2017-2022 Cloudflare, Inc. | |||
Contributor
There was a problem hiding this comment.
Does this copyright need adjusting?
Contributor
Author
There was a problem hiding this comment.
Fixed the copyright years
fhanau
force-pushed
the
felix/node-crypto-hkdf
branch
from
69f91a4 to
2040fb0
Compare
Contributor
Author
|
Corrected the copyright messages, also switched to a different approach to do HKDF that works with older bssl versions. It turns out that this approach is also much simpler as bssl's HKDF() function handles edge cases that OpenSSL does not, which allows us to greatly simplify the C++ code |
fhanau
force-pushed
the
felix/node-crypto-hkdf
branch
from
2040fb0 to
cc16f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.