Skip to content

[nfc] Update rules_rust, further rust cleanup#850

Merged
fhanau merged 1 commit intomainfrom
felix/rust-cleanup-v2
Jul 12, 2023
Merged

[nfc] Update rules_rust, further rust cleanup#850
fhanau merged 1 commit intomainfrom
felix/rust-cleanup-v2

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Jul 10, 2023

Changes:

  • Update rules_rust and cargo-bazel to the latest version. Add generate_target_compatible_with=False, otherwise this update would result in unnecessarily listing the supported platforms in each build file. Similarly, remove a workaround where "wasm32-unknown-unknown" was among the supported platforms, which is no longer needed.
  • Add -C embed-bitcode=no to the rust flags (a free win as this is only needed when LTO is enabled).
  • Remove addr2line (no longer needed) and libc (only used indirectly, no need to pin/specify it) from the pinned crates
  • Update flate2 pin, although the latest version was apparently already being used
  • Remove unused rules_foreign_cc from WORKSPACE

Note that based on the files being changed this does not affect upstream, but the corresponding upstream PR can still be a good reference as there is significant overlap

@fhanau fhanau requested review from mikea and ohodson July 10, 2023 18:40
@fhanau fhanau force-pushed the felix/rust-cleanup-v2 branch 2 times, most recently from c835783 to 803b611 Compare July 11, 2023 13:55
@fhanau fhanau force-pushed the felix/rust-cleanup-v2 branch from 803b611 to e7d7a5d Compare July 11, 2023 14:02
@fhanau fhanau changed the title Update rules_rust, further rust cleanup [nfc] Update rules_rust, further rust cleanup Jul 11, 2023
@fhanau fhanau merged commit cb61734 into main Jul 12, 2023
@fhanau fhanau deleted the felix/rust-cleanup-v2 branch July 12, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants