Conversation
fhanau
force-pushed
the
felix/bazel-win-exp
branch
6 times, most recently
from
3aa964b to
1c51838
Compare
fhanau
force-pushed
the
felix/bazel-win-exp
branch
from
1c51838 to
5610487
Compare
fhanau
force-pushed
the
felix/bazel-win-exp
branch
from
5610487 to
9ce41e4
Compare
fhanau
changed the title
fhanau
force-pushed
the
felix/bazel-win-exp
branch
from
c751d30 to
eb524bd
Compare
The issue has been fixed upstream in https://chromium-review.googlesource.com/c/v8/v8/+/4218733.
fhanau
force-pushed
the
felix/bazel-win-exp
branch
from
eb524bd to
ed55fd4
Compare
mrbbot
approved these changes
Jul 10, 2023
mikea
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits simplify the bazel build and should make future V8 updates easier:
alwayslink=0changes was used for noicu compile targets. Since we always build with ICU, these targets never get built and there's no need to change them.