Revert "Delete all alarms on abortAllDurableObjects()"#6355
Merged
Conversation
Contributor
|
The revert is a clean, exact inverse of PR #1918. Every addition in #1918 is removed in #6355, and every removal in #1918 is restored. The changes are:
No residual references to the removed functionality, no behavioral changes beyond the revert, no backward compatibility concerns (the reverted feature was internal/unsafe-module only). The PR description's rationale is sound — cancelling alarms without deleting all data leaves DOs in an inconsistent state. LGTM |
jasnell
approved these changes
Mar 18, 2026
petebacondarwin
approved these changes
Mar 18, 2026
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
I think there is still a need for deleting alarms in tests but something that can be worked on separately.
Member
Author
|
Internal build flaked twice on a test that literally does not compile in any of the code modified in this PR, so I bypassed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1918
Ironically, a week after this PR was merged, vitest-pool-workers actually removed its usage of this API. After two years of waiting...
And after some discussion, we feel that it doesn't make sense for abortAllDurableObjects() to cancel alarms. Cancelling alarms is essentially deleting data from the DOs, but since it doesn't delete all data, it leaves them in an inconsistent state.
It could make sense to add a new deleteAllDurableObjects() API which aborts DOs, cancels alarms, and deletes underlying data, but that should be a separate API.