Change Pyodide code to ensure all fatals are reported.

[dom96]

The code for this is here: https://github.com/pyodide/pyodide/blob/0.28.2/src/core/error_handling.ts#L92. The on_fatal method is only called when the fatal happens for the first time. This change should ensure it gets called even if the fatal occurred already.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This change patches Pyodide's fatal_error to invoke API.on_fatal(e) in the recursive-call path, ensuring all fatal errors are reported rather than only the first one.

Issues found (ranked by severity):

1. [MEDIUM] Missing try/catch around on_fatal in the recursive path. In the original non-recursive path, API.on_fatal(e) is called inside a try { ... } catch block. But in this patch, the call is unguarded. If on_fatal itself throws, the return statement won't execute, and fatal_error will continue into the rest of its body, which could cause an infinite recursion or other unexpected behavior.

---

These comments were generated by an AI code review assistant and may contain errors. Please verify all suggestions before applying.

[ask-bonk]

Review posted successfully on PR #6334.

Summary: The PR patches Pyodide's fatal_error function to call API.on_fatal(e) during recursive fatal errors (not just the first one). I found one medium-severity issue: the on_fatal call in the new code path is unguarded, unlike the original non-recursive path where it's wrapped in a try/catch. If on_fatal throws, the return won't execute, potentially causing further problems. I posted a suggestion to wrap the call in a try/catch.

github run

[hoodmane]

Running Build Python Runtime workflow on this, we need tests to pass after that workflow pushes an update to this branch.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7143daf). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6334   +/-   ##
=======================================
  Coverage        ?   70.80%           
=======================================
  Files           ?      420           
  Lines           ?   112589           
  Branches        ?    18447           
=======================================
  Hits            ?    79719           
  Misses          ?    21869           
  Partials        ?    11001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.