Add WORKER_LOADER.load() for one-off workers. #6316
Merged
Conversation
This is a pure code move into a helper function.
Contributor
|
LGTM |
kentonv
force-pushed
the
kenton/worker-loader-load
branch
from
37019c4 to
8969e17
Compare
|
The generated output of |
kentonv
force-pushed
the
kenton/worker-loader-load
branch
from
8969e17 to
79d7d94
Compare
`LOADER.load(code)` is equivalent to `LOADER.get(null, () => code)`. This change got annoying to the pesky detail that the system might call the callback multiple times, forcing me to create clone() methods for a bunch of structures so that I could build the structure ones and return a clone on every call. The source code itself is refcounted between these clones, at least.
kentonv
force-pushed
the
kenton/worker-loader-load
branch
from
79d7d94 to
e945af7
Compare
jasnell
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOADER.load(code)is equivalent toLOADER.get(null, () => code). This is nice for the common use case of e.g. agent-generated one-off code.This change got annoying to the pesky detail that the system might call the callback multiple times, forcing me to create clone() methods for a bunch of structures so that I could build the structure ones and return a clone on every call. The source code itself is refcounted between these clones, at least.
Note: Eventually we might support plain RPC stubs in
envin this case, but that's a deep change which I'm not going to attempt right now.