feat: Add origin header to ThreadContext::HeaderIdBundle for internal…#6297
feat: Add origin header to ThreadContext::HeaderIdBundle for internal…#6297
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds an origin (Origin) header ID to ThreadContext::HeaderIdBundle.
Issues (ranked by severity):
-
[MEDIUM] No usages of the new field. The
originheader ID is registered in the bundle but is not referenced anywhere in the codebase. Every other field inHeaderIdBundlehas a comment documenting its purpose (e.g.,// used by cache API implementation,// used in tracing instrumentation). Without a consumer, this is dead code — it increases the header table size for every thread context with no benefit. Could you either (a) add the code that uses it in this PR, or (b) explain the intended consumer so reviewers can evaluate whether this addition is appropriate? -
[LOW] Missing usage comment. All other fields in the struct have a
// used by …comment. The new field should follow the same convention.
See inline comments for details.
This review was generated by an AI assistant and may contain errors. Please verify all suggestions before applying.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds an
Review posted at: #6297 (review) |
… use