Skip to content

containers: intercept http gets out of experimental land#6278

Merged
gabivlj merged 2 commits intomainfrom
gv/upgrade-from-exp
Mar 9, 2026
Merged

containers: intercept http gets out of experimental land#6278
gabivlj merged 2 commits intomainfrom
gv/upgrade-from-exp

Conversation

@gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Mar 9, 2026

No description provided.

gabivlj and others added 2 commits March 9, 2026 11:22
@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 9, 2026

The change is very small and clean. Let me verify there are no other concerns:

  1. Two methods (interceptOutboundHttp, interceptAllOutboundHttp) are being ungated from getWorkerdExperimental() in the JSG_RESOURCE_TYPE registration.
  2. Type snapshots are updated in latest/ to include these methods (they were already in experimental/).
  3. The implementation in container.c++ has no experimental gating — the methods themselves never checked getWorkerdExperimental() at runtime, only the JSG registration was conditional.

This is a straightforward promotion of two methods from experimental to stable. The Container API is already a non-experimental feature (most methods are unconditionally registered), and these two methods are simply joining the rest. There are no backward compatibility concerns since this is purely additive — methods that were only available with the experimental flag are now available to everyone.

No issues found with this change.

LGTM

github run

@gabivlj gabivlj marked this pull request as ready for review March 9, 2026 16:35
@gabivlj gabivlj requested review from a team as code owners March 9, 2026 16:35
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2026

Merging this PR will improve performance by 26.58%

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
bodyWithHeaders[Response] 38.6 µs 30.5 µs +26.58%

Comparing gv/upgrade-from-exp (77feeb0) with main (2536901)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gabivlj gabivlj enabled auto-merge March 9, 2026 17:51
@gabivlj gabivlj merged commit d7dc27c into main Mar 9, 2026
24 of 26 checks passed
@gabivlj gabivlj deleted the gv/upgrade-from-exp branch March 9, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants