Fire close event for server WebSocket close, with allowHalfOpen opt-out.#6197
Merged
Fire close event for server WebSocket close, with allowHalfOpen opt-out.#6197
Conversation
b0eba29 to
b4d604c
Compare
jasnell
reviewed
Feb 26, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6197 +/- ##
==========================================
- Coverage 70.73% 70.64% -0.09%
==========================================
Files 420 420
Lines 111371 111390 +19
Branches 18349 18353 +4
==========================================
- Hits 78777 78692 -85
- Misses 21629 21738 +109
+ Partials 10965 10960 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jp4a50
reviewed
Feb 27, 2026
jp4a50
reviewed
Feb 27, 2026
jp4a50
reviewed
Feb 27, 2026
jp4a50
reviewed
Feb 27, 2026
Collaborator
|
Overall I'm fine with this approach. I'll do a final review pass once @jp4a50's reviews are addressed but currently not seeing anything else here that would be blocking. |
b4d604c to
171a30f
Compare
jasnell
reviewed
Mar 2, 2026
This comment was marked as outdated.
This comment was marked as outdated.
d64867d to
053a5bd
Compare
jp4a50
approved these changes
Mar 2, 2026
Contributor
jp4a50
left a comment
There was a problem hiding this comment.
Pre-emptively approving on the assumption that the compat flag's enable and disable names are flipped!
053a5bd to
11df51a
Compare
11df51a to
d9e7f2c
Compare
|
The generated output of |
0ea62e9 to
b2d70fa
Compare
petebacondarwin
approved these changes
Mar 6, 2026
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
From the point of view of the TS typings.
kentonv
reviewed
Mar 6, 2026
jasnell
reviewed
Mar 6, 2026
b2d70fa to
8f349d8
Compare
8f349d8 to
2afda3e
Compare
2 tasks
kentonv
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information, read the docs pull-request: cloudflare/cloudflare-docs#28887