Skip to content

Fire close event for server WebSocket close, with allowHalfOpen opt-out.#6197

Merged
anonrig merged 1 commit intomainfrom
yagiz/add-websocket-allow-half-open
Mar 10, 2026
Merged

Fire close event for server WebSocket close, with allowHalfOpen opt-out.#6197
anonrig merged 1 commit intomainfrom
yagiz/add-websocket-allow-half-open

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Feb 26, 2026

For more information, read the docs pull-request: cloudflare/cloudflare-docs#28887

@anonrig anonrig requested review from a team as code owners February 26, 2026 23:03
@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch from b0eba29 to b4d604c Compare February 26, 2026 23:08
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.64%. Comparing base (1f0f17f) to head (2afda3e).

Files with missing lines Patch % Lines
src/workerd/api/web-socket.c++ 89.28% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6197      +/-   ##
==========================================
- Coverage   70.73%   70.64%   -0.09%     
==========================================
  Files         420      420              
  Lines      111371   111390      +19     
  Branches    18349    18353       +4     
==========================================
- Hits        78777    78692      -85     
- Misses      21629    21738     +109     
+ Partials    10965    10960       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
Copy link
Collaborator

jasnell commented Feb 27, 2026

Overall I'm fine with this approach. I'll do a final review pass once @jp4a50's reviews are addressed but currently not seeing anything else here that would be blocking.

@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch from b4d604c to 171a30f Compare March 2, 2026 14:33
@jasnell jasnell requested a review from MellowYarker March 2, 2026 14:39
@anonrig anonrig requested review from jasnell and jp4a50 March 2, 2026 14:40
@codspeed-hq

This comment was marked as outdated.

@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch 3 times, most recently from d64867d to 053a5bd Compare March 2, 2026 20:35
Copy link
Contributor

@jp4a50 jp4a50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptively approving on the assumption that the compat flag's enable and disable names are flipped!

@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch from 053a5bd to 11df51a Compare March 2, 2026 20:56
@anonrig anonrig requested a review from jasnell March 3, 2026 20:29
@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch from 11df51a to d9e7f2c Compare March 5, 2026 19:04
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch 3 times, most recently from 0ea62e9 to b2d70fa Compare March 5, 2026 19:54
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the point of view of the TS typings.

@anonrig anonrig force-pushed the yagiz/add-websocket-allow-half-open branch from b2d70fa to 8f349d8 Compare March 6, 2026 18:32
@anonrig anonrig merged commit 8a0534f into main Mar 10, 2026
33 of 34 checks passed
@anonrig anonrig deleted the yagiz/add-websocket-allow-half-open branch March 10, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants