Skip to content

[nfc] Use wpt-report config for test-linux#6138

Merged
npaun merged 2 commits intomainfrom
npaun/test-linux-wpt
Feb 23, 2026
Merged

[nfc] Use wpt-report config for test-linux#6138
npaun merged 2 commits intomainfrom
npaun/test-linux-wpt

Conversation

@npaun
Copy link
Member

@npaun npaun commented Feb 23, 2026

This makes it so the WPT tests are always run under the test-linux build, so we always get a WPT report for a PR

This makes it so the WPT tests are always run under the test-linux build, so we always get a WPT report for a PR
@npaun npaun requested review from a team as code owners February 23, 2026 18:56
@fhanau
Copy link
Contributor

fhanau commented Feb 23, 2026

This looks good at face value, but will cause a Bazel warning... The wpt-test config will now be expanded twice (from wpt-report and from ci-test). Bazel produces a warning whenever configs are expanded twice. In practice this might just be fine as --test_env=GEN_TEST_REPORT=1 and --test_env=GEN_TEST_STATS=1 will be duplicated; since we're passing the same values again this should make no difference.
I will approve, but if you can come up with an elegant way to avoid this we should do it

@npaun
Copy link
Member Author

npaun commented Feb 23, 2026

@fhanau Might be as simple as removing wpt-test from wpt-report and passing both in the wpt-report.yml workflow actually that one already uses ci-test so there's nothing to do.

@npaun npaun requested a review from a team as a code owner February 23, 2026 19:06
@fhanau
Copy link
Contributor

fhanau commented Feb 23, 2026

That looks reasonable, the only time one would need to pass wpt-report is on CI, for local builds that want the report you'd pass wpt-test. Note that wpt-report is enabled in release CI though – we still need to have wpt-test there.

@npaun npaun force-pushed the npaun/test-linux-wpt branch from 8e5892d to ccc7e52 Compare February 23, 2026 19:11
@npaun
Copy link
Member Author

npaun commented Feb 23, 2026

Note that wpt-report is enabled in release CI though – we still need to have wpt-test there.

Thanks for spotting that!

@npaun npaun enabled auto-merge (squash) February 23, 2026 19:54
@npaun npaun merged commit fe9c1a6 into main Feb 23, 2026
22 of 23 checks passed
@npaun npaun deleted the npaun/test-linux-wpt branch February 23, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants