Optimize single-batch delete flushes in ActorCache#338
Merged
a-robinson merged 3 commits intomainfrom Feb 1, 2023
Merged
Conversation
...in advance of adding an additional case or two
This is the same thing we already do for unaccompanied put() batches and alarm writes, but now also for unaccompanied muted delete batches.
This is the same thing we already do for unaccompanied put() batches, alarm writes, and muted delete batches, but now also for counted deletes that require only a single delete RPC in order to be satisfied.
bcaimano
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just doing the same thing for deletes (both muted and batch) that we already do for puts and alarm writes. Sorry for letting this sit for so long without finishing it up (especially since deletes should benefit the most from not needing transactions due to a quirk within cockroach transaction pipelining).
This PR is the same as #337, but this time from a branch in the main repo as opposed to a branch on my fork (so that CI will finish in a reasonable amount of time). Sorry for the noise -- I've now updated my local setup to make it much harder for me to make this mistake again.