Skip to content

pre-commit hook to check for KJ_DBG in source files#1060

Merged
mikea merged 1 commit intomainfrom
maizatskyi/2023-08-24-kj_dbg_hook
Aug 24, 2023
Merged

pre-commit hook to check for KJ_DBG in source files#1060
mikea merged 1 commit intomainfrom
maizatskyi/2023-08-24-kj_dbg_hook

Conversation

@mikea
Copy link
Contributor

@mikea mikea commented Aug 24, 2023 •
edited
Loading

#1059 will actually execute this.

Example while trying to commit this change:

$ git commit -a
+DISALLOWED_PATTERN='KJ_DBG'

ERROR, disallowed text patterns detected.
To commit anyway, use --no-verify

@mikea mikea requested review from jasnell, kentonv and ohodson August 24, 2023 18:04
@mikea mikea force-pushed the maizatskyi/2023-08-24-kj_dbg_hook branch from f0386cf to 2a4739d Compare August 24, 2023 18:06
@ohodson
Copy link
Contributor

ohodson commented Aug 24, 2023

It might be worth adding a pointer to the guidance in kj/debug.h that suggests doing just this.

@mikea mikea force-pushed the maizatskyi/2023-08-24-kj_dbg_hook branch from 2a4739d to 01fd5f4 Compare August 24, 2023 20:00
@mikea mikea merged commit 9929604 into main Aug 24, 2023
@mikea mikea deleted the maizatskyi/2023-08-24-kj_dbg_hook branch August 24, 2023 21:10
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Check for githooks configuration on Windows
b7869f4 
Follow-up to #1059
and #1060
@ohodson ohodson mentioned this pull request Sep 1, 2023
Merged
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Check for githooks configuration on Windows
d03a51b 
Follow-up to #1059
and #1060
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Check for githooks configuration on Windows
a6f0ce1 
Follow-up to #1059
and #1060
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Check for githooks configuration on Windows
f34d03c 
Follow-up to #1059
and #1060
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Add workspace-status.cmd for Windows
75fb464 
This is just a wrapper that invokes bash to run
`tools/unix/workspace-status.sh`.

Follow-up to #1059
and #1060
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Add workspace-status.cmd for Windows
8da4942 
This is just a wrapper that invokes bash to run
`tools/unix/workspace-status.sh`.

Follow-up to #1059
and #1060
ohodson pushed a commit that referenced this pull request Sep 1, 2023
Add workspace-status.cmd for Windows
006d821 
This is just a wrapper that invokes bash to run
`tools/unix/workspace-status.sh`.

Follow-up to #1059
and #1060
ohodson pushed a commit that referenced this pull request Sep 1, 2023
@ohodson
Add workspace-status.cmd for Windows
8aabe6a 
This is just a wrapper that invokes bash to run
`tools/unix/workspace-status.sh`.

Follow-up to #1059
and #1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@kentonv kentonv Awaiting requested review from kentonv

+1 more reviewer

@ohodson ohodson ohodson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikea @ohodson @jasnell