Merged
Conversation
mikea
force-pushed
the
maizatskyi/2023-08-15-lazy-cf-parsing
branch
2 times, most recently
from
47a296e to
9e8861c
Compare
Contributor
Author
|
downstream PR 5982 |
jasnell
reviewed
Aug 16, 2023
jasnell
reviewed
Aug 16, 2023
mikea
force-pushed
the
maizatskyi/2023-08-15-lazy-cf-parsing
branch
from
f689c8e to
cc0a450
Compare
jasnell
approved these changes
Aug 17, 2023
fhanau
approved these changes
Aug 17, 2023
mikea
force-pushed
the
maizatskyi/2023-08-15-lazy-cf-parsing
branch
from
cc0a450 to
8e67e9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted all logic to handle the value to a separate class.
Most customers don't need this. Shaves off 6-10ns (10%) on hello world :)
lazy cf parsing:
iteration_duration.............: avg=76.65µs min=52.06µs med=65.46µs max=25.35ms p(90)=91.45µs p(95)=108.09µsmain:
iteration_duration.............: avg=87.73µs min=58.69µs med=74.47µs max=20.27ms p(90)=107.58µs p(95)=120.31µs