Skip to content

connections update#616

Merged
abracchi-tw merged 2 commits intoproductionfrom
connections
Jan 8, 2021
Merged

connections update#616
abracchi-tw merged 2 commits intoproductionfrom
connections

Conversation

@TownLake
Copy link
Copy Markdown
Contributor

@TownLake TownLake commented Jan 8, 2021

No description provided.

@TownLake TownLake requested a review from abracchi-tw January 8, 2021 13:18
@abracchi-tw abracchi-tw merged commit 9e9b016 into production Jan 8, 2021
@abracchi-tw abracchi-tw deleted the connections branch January 8, 2021 13:56
threepointone pushed a commit that referenced this pull request Nov 17, 2025
Updates schedule-tasks.mdx to reflect changes from cloudflare/agents#653:

- Add example showing immediate task scheduling (delay = 0)
- Document safe usage of destroy() within scheduled callbacks
- Explain that Agent SDK defers destruction to ensure scheduled tasks complete

Addresses the fix for issue #616 where calling destroy() inside a schedule
would cause errors and retry loops.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mattzcarey pushed a commit that referenced this pull request Jan 16, 2026
* Document destroy() behavior in scheduled tasks

Updates documentation to reflect that destroy() can now be safely called
within scheduled task callbacks. The Agent properly handles cleanup by:
- Setting an internal flag to skip remaining database updates
- Yielding ctx.abort() to the event loop for clean alarm handler completion

This addresses the fix in cloudflare/agents#653 where calling destroy()
inside a schedule previously caused errors.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Document destroy() behavior in scheduled tasks

Updates documentation to reflect that destroy() can now be safely called
from within scheduled task callbacks. The Agent SDK now:
- Sets an internal flag to prevent database updates after destruction
- Defers ctx.abort() to the event loop to allow handlers to complete

Related to cloudflare/agents#653

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Document destroy() behavior in scheduled tasks and immediate scheduling

Updates schedule-tasks.mdx to reflect changes from cloudflare/agents#653:

- Add example showing immediate task scheduling (delay = 0)
- Document safe usage of destroy() within scheduled callbacks
- Explain that Agent SDK defers destruction to ensure scheduled tasks complete

Addresses the fix for issue #616 where calling destroy() inside a schedule
would cause errors and retry loops.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants