Remove basePath room/party workaround#869
Conversation
Stop injecting `party`/`room` into socket options when `basePath` is provided. PartySocket now handles reconnects without requiring a `room`, so AgentClient and useAgent no longer add `party`/`room` for basePath mode. Update changesets to remove the previous workaround and simplify the earlier fix description.
🦋 Changeset detectedLatest commit: e592460 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Claude Code ReviewSummary: PR looks good. Clean removal of a workaround after upstream fix. Code Changes: The PR properly removes the party/room injection workaround from both AgentClient (client.ts:169) and useAgent (react.tsx:439-443) for basePath mode. The changes are consistent across both files. Changesets: Two changesets are appropriate - one updating the description of the original fix, another documenting the workaround removal. Testing Gap: The existing basepath.test.ts has comprehensive coverage for basePath routing functionality, but doesn't explicitly test reconnect scenarios. Consider adding a test that verifies reconnection works correctly with basePath mode (though this may be better suited for partysocket's test suite). Minor Note: The PR description says "PartySocket now handles reconnects without requiring a room" - you may want to reference the specific partysocket version or commit that fixed this for future maintainers. Otherwise, this is a straightforward cleanup that improves code clarity by removing a documented workaround. |
commit: |
Stop injecting
party/roominto socket options whenbasePathis provided. PartySocket now handles reconnects without requiring aroom, so AgentClient and useAgent no longer addparty/roomfor basePath mode. Update changesets to remove the previous workaround and simplify the earlier fix description.