Skip to content

Remove basePath room/party workaround#869

Merged
threepointone merged 1 commit intomainfrom
remove-party-workaround
Feb 8, 2026
Merged

Remove basePath room/party workaround#869
threepointone merged 1 commit intomainfrom
remove-party-workaround

Conversation

@threepointone
Copy link
Copy Markdown
Contributor

Stop injecting party/room into socket options when basePath is provided. PartySocket now handles reconnects without requiring a room, so AgentClient and useAgent no longer add party/room for basePath mode. Update changesets to remove the previous workaround and simplify the earlier fix description.

Stop injecting `party`/`room` into socket options when `basePath` is provided. PartySocket now handles reconnects without requiring a `room`, so AgentClient and useAgent no longer add `party`/`room` for basePath mode. Update changesets to remove the previous workaround and simplify the earlier fix description.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 8, 2026

🦋 Changeset detected

Latest commit: e592460

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown

claude bot commented Feb 8, 2026

Claude Code Review

Summary: PR looks good. Clean removal of a workaround after upstream fix.

Code Changes: The PR properly removes the party/room injection workaround from both AgentClient (client.ts:169) and useAgent (react.tsx:439-443) for basePath mode. The changes are consistent across both files.

Changesets: Two changesets are appropriate - one updating the description of the original fix, another documenting the workaround removal.

Testing Gap: The existing basepath.test.ts has comprehensive coverage for basePath routing functionality, but doesn't explicitly test reconnect scenarios. Consider adding a test that verifies reconnection works correctly with basePath mode (though this may be better suited for partysocket's test suite).

Minor Note: The PR description says "PartySocket now handles reconnects without requiring a room" - you may want to reference the specific partysocket version or commit that fixed this for future maintainers.

Otherwise, this is a straightforward cleanup that improves code clarity by removing a documented workaround.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 8, 2026

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/agents@869

commit: e592460

@threepointone threepointone merged commit fc17506 into main Feb 8, 2026
5 checks passed
@threepointone threepointone deleted the remove-party-workaround branch February 8, 2026 23:43
@github-actions github-actions bot mentioned this pull request Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant