fix: use Object.getOwnPropertyDescriptor for property check#446
Merged
threepointone merged 2 commits intocloudflare:mainfrom Sep 9, 2025
Merged
fix: use Object.getOwnPropertyDescriptor for property check#446threepointone merged 2 commits intocloudflare:mainfrom
threepointone merged 2 commits intocloudflare:mainfrom
Conversation
The commit relies on `Object.getOwnPropertyDescriptor` to safely inspect if a property is a method or a getter without invoking it.
🦋 Changeset detectedLatest commit: b8cdb3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Flouse
commented
Sep 9, 2025
| continue; | ||
| } | ||
| // If the method doesn't exist in base prototypes, it's a custom method | ||
| if (!baseMethods.has(methodName)) { |
Contributor
Author
There was a problem hiding this comment.
It was duplicated check of L859, so I removed it.
commit: |
threepointone
approved these changes
Sep 9, 2025
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
looks good, thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit relies on
Object.getOwnPropertyDescriptorto safely inspect if a property is a method or a getter without invoking it._autoWrapCustomMethodsmay inadvertently execute getters when checking property type #432