Skip to content

Fix onConnect race condition#436

Merged
threepointone merged 6 commits intomainfrom
fix-connect-race
Sep 4, 2025
Merged

Fix onConnect race condition#436
threepointone merged 6 commits intomainfrom
fix-connect-race

Conversation

@deathbyknowledge
Copy link
Copy Markdown
Member

@deathbyknowledge deathbyknowledge commented Sep 4, 2025

Fixes #321 and adds test for message ordering.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 56abc9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
agents Patch
hono-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/agents@436

commit: 56abc9f

@deathbyknowledge deathbyknowledge marked this pull request as ready for review September 4, 2025 12:30
@whoiskatrin
Copy link
Copy Markdown
Contributor

tentatively looks ok to me

@threepointone threepointone merged commit 8dac62c into main Sep 4, 2025
3 checks passed
@threepointone threepointone deleted the fix-connect-race branch September 4, 2025 14:00
@threepointone threepointone mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition: onMessage() can be called before onConnect()

3 participants