Refactor message types to use enum in AIChatAgent and related files#409
Merged
threepointone merged 5 commits intocloudflare:mainfrom Aug 18, 2025
Merged
Refactor message types to use enum in AIChatAgent and related files#409threepointone merged 5 commits intocloudflare:mainfrom
threepointone merged 5 commits intocloudflare:mainfrom
Conversation
Contributor
MrgSub
commented
Aug 14, 2025
MrgSub
commented
- Updated message type references in ai-chat-agent.ts, ai-react.tsx, and other files to use the new MessageType enum.
- Removed unused imports and ensured consistent usage of message types across the codebase.
🦋 Changeset detectedLatest commit: da32723 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…dy more efficiently
…ingResponse classes
commit: |
Merged
nickfujita
reviewed
Aug 22, 2025
| for await (const chunk of response.body!) { | ||
| const body = decoder.decode(chunk); | ||
|
|
||
| this._broadcastChatMessage({ |
Contributor
There was a problem hiding this comment.
why was this broadcast of the text chunks to the client removed? _drainStream seems to perform the chunk decode, but never broadcasts the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.