-
Notifications
You must be signed in to change notification settings - Fork 469
feat: add auto transport for client #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
threepointone
merged 3 commits into
cloudflare:main
from
amorriscode:amorriscode/auto-transport
Jul 31, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "agents": patch | ||
| --- | ||
|
|
||
| add auto transport option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| import { createExecutionContext, env } from "cloudflare:test"; | ||
| import { describe, expect, it, beforeEach, afterEach } from "vitest"; | ||
| import worker, { type Env } from "../../worker"; | ||
| import { initializeMCPClientConnection } from "../../shared/test-utils"; | ||
|
|
||
| declare module "cloudflare:test" { | ||
| interface ProvidedEnv extends Env {} | ||
| } | ||
|
|
||
| /** | ||
| * Tests for the "auto" transport mode which attempts streamable-http first, | ||
| * then falls back to SSE if streamable-http returns 404 or 405 errors | ||
| */ | ||
| describe("Auto Transport Mode", () => { | ||
| const originalFetch = globalThis.fetch; | ||
|
|
||
| beforeEach(() => { | ||
| globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit) => { | ||
| const ctx = createExecutionContext(); | ||
| const request = new Request(input, init); | ||
| return worker.fetch(request, env, ctx); | ||
| }; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| globalThis.fetch = originalFetch; | ||
| }); | ||
|
|
||
| describe("Transport Selection Logic", () => { | ||
| it("should use connect using streamable-http when available", async () => { | ||
| const connection = await initializeMCPClientConnection( | ||
| "http://example.com/mcp", | ||
| "auto" | ||
| ); | ||
|
|
||
| await connection.init(); | ||
|
|
||
| expect(connection.connectionState).toBe("ready"); | ||
| expect(connection.tools).toBeDefined(); | ||
| }); | ||
|
|
||
| it("should use connect using sse when available", async () => { | ||
| const connection = await initializeMCPClientConnection( | ||
| "http://example.com/sse", | ||
| "auto" | ||
| ); | ||
|
|
||
| await connection.init(); | ||
|
|
||
| expect(connection.connectionState).toBe("ready"); | ||
| expect(connection.tools).toBeDefined(); | ||
| }); | ||
|
|
||
| it("should not fallback for 5XX errors", async () => { | ||
| const connection = await initializeMCPClientConnection( | ||
| "http://example.com/500", | ||
| "auto" | ||
| ); | ||
|
|
||
| await expect(connection.init()).rejects.toThrow(); | ||
| expect(connection.connectionState).toBe("failed"); | ||
| }); | ||
|
|
||
| it("should fail when endpoint returns 404 for both streamable-http and sse", async () => { | ||
| const connection = await initializeMCPClientConnection( | ||
| "http://example.com/not-found", | ||
| "auto" | ||
| ); | ||
|
|
||
| await expect(connection.init()).rejects.toThrow(); | ||
| expect(connection.connectionState).toBe("failed"); | ||
| }); | ||
|
|
||
| it("should fail when asking for an incorrect transport type", async () => { | ||
| const connection = await initializeMCPClientConnection( | ||
| "http://example.com/mcp", | ||
| "sse" | ||
| ); | ||
|
|
||
| await expect(connection.init()).rejects.toThrow(); | ||
| expect(connection.connectionState).toBe("failed"); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was struggling to get the tests to pass when passing the entire request to
onSSEMcpMessage. I noticed that the only thing it actually needs is the message body so being explicit seemed okay.