Merged
Conversation
For instance, Methods<T> not enforcing values to be a Method was causing problems on other types.
🦋 Changeset detectedLatest commit: 409dcad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the final version! Even if the previous version was passing the tests, I was not happy with those types because I couldn't understand why they were not behaving the way I expected them to.
For instance,
Methods<T>should return a object type with onlyMethodvalues, something similar toRecord<string, Method>but if I tried to useParameters<Method<T>[K]>it would fail, which was odd.It turns out I was missing a condition in the
Method<T>value, even if its keys were already using the same condition.After fixing that one and
OptionalAgentMethods, which had the same problem, I was able to simplify the remaining types, likeAgentStub<T>which no longer needs to be atype AgentStub<T extends AgentMethods<T>>.