Adding mcp-session-id to McpAgents' CORS headers to permit web-based MCP clients#261
Merged
threepointone merged 5 commits intomainfrom May 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 3fd86df The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This now includes `mcp-session-id` in `Access-Control-Expose-Headers` and `Access-Control-Allow-Headers`, otherwise StreamableHTTP transport servers can't be used from web-based MCP Clients
geelen
force-pushed
the
mcp-streamable-cors-session-header
branch
from
fc6a5b1 to
f16c726
Compare
Contributor
|
lemme fix the build failures for you |
| tsconfigs.map((tsconfig) => execSync(`tsc -p ${tsconfig}`)) | ||
| ) | ||
| ).filter((r) => r.status === "rejected"); | ||
| type Result = { |
Contributor
There was a problem hiding this comment.
thanks for this! so much nicer
threepointone
approved these changes
May 7, 2025
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
looks great, approving and landing
Merged
This was referenced Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now includes
mcp-session-idinAccess-Control-Expose-HeadersandAccess-Control-Allow-Headers, otherwise StreamableHTTP transport servers can't be used from web-based MCP Clients.This has been added to all 2xx responses from McpAgents