Update Agent.alarm to readonly, linking to schedule-task docs#260
Merged
threepointone merged 3 commits intocloudflare:mainfrom May 7, 2025
Merged
Update Agent.alarm to readonly, linking to schedule-task docs#260threepointone merged 3 commits intocloudflare:mainfrom
threepointone merged 3 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 71d1d27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Agent class has a custom implementation for scheduled tasks via
this.schedule, if thealarmclass is implemented on a subclass, it doesn't perform as expected. While a quick trip to the docs would point you in this direction, it would be nice to have a ts error and js doc explaining that instead of implementing alarm, use the schedule method instead. Was able to find a solution to provide a type warning in one case, but not sure if there is a better way to do this to catch all cases?Test happy path
AIChatAgentclass, add a dummy alarm methodAIChatAgentshouldn't be called, only the one onAgentPossible subversion
If the user reads the error they could actually just get around this by instead adding to
AIChatAgentSo it's not a fool proof solution, but the hope is that it would guard the majority that just follow the cloudflare docs on how to implement alarms.