Automatically change "/" path to "/*" in MCP server mount() method#149
Merged
threepointone merged 3 commits intocloudflare:mainfrom Apr 5, 2025
Merged
Automatically change "/" path to "/*" in MCP server mount() method#149threepointone merged 3 commits intocloudflare:mainfrom
threepointone merged 3 commits intocloudflare:mainfrom
Conversation
Fixes cloudflare#148 Could instead throw an error here and ask people to set this themselves. But having hard time seeing problematic case if we just made it work as people might expect, who aren't thinking about the `path` argument as something that gets fed into `URLPattern`?
🦋 Changeset detectedLatest commit: d1f497c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
landing this, lgtm |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Could instead throw an error here and ask people to set this themselves. But having hard time seeing problematic case if we just made it work as people might expect, who aren't thinking about the
pathargument as something that gets fed intoURLPattern?