fuse: Ensure readdir returns same ino as lookup#140
Merged
bergwolf merged 1 commit intocloud-hypervisor:masterfrom Jul 7, 2023
Merged
Conversation
The filesystem test utility xfs-tests[1] failed on test generic/637 with the error entry 8 has inode 72057594038044051, expected 112052 The expected inode returned from readdir is neither converted nor the same inode as assigned by do_lookup, as stated in the docs for DirEntry.ino. Update readdir to perform do_lookup to get the correct inode number and then convert this inode number to the expected format. After this change the test generic/637 passes and no regressions in other tests. [1] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/ Signed-off-by: Champ-Goblem <cameron@northflank.com>
Champ-Goblem
requested review from
bergwolf,
eryugey,
imeoer,
jiangliu and
liubogithub
as code owners
Contributor
Author
|
Thinking about it the and then restore the old Self::stat code so that pseudo fs has the correct ino? |
bergwolf
approved these changes
Jul 7, 2023
Contributor
bergwolf
left a comment
bergwolf
left a comment
There was a problem hiding this comment.
lgtm, thanks! Let's just add do_lookup in passthroughfs as backendfs is supposed to return its own inode number in fs.readdir and it is just passthroufs's requirement to allocate the inode number through do_lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filesystem test utility xfs-tests[1] failed on test generic/637 with the error entry 8 has inode 72057594038044051, expected 112052. The expected inode returned from readdir is neither converted nor the same inode as assigned by do_lookup, as stated in the docs for DirEntry.ino.
Update readdir to perform do_lookup to get the correct inode number and then convert this inode number to the expected format.
After this change the test generic/637 passes and no regressions in other tests.
[1] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/