Skip to content

[ENH] add pytest exit-on-first-failure flag to GitHub workflows#6761

Open
rescrv wants to merge 3 commits intomainfrom
rescrv/pytest-x
Open

[ENH] add pytest exit-on-first-failure flag to GitHub workflows#6761
rescrv wants to merge 3 commits intomainfrom
rescrv/pytest-x

Conversation

@rescrv
Copy link
Copy Markdown
Contributor

@rescrv rescrv commented Mar 27, 2026

Description of changes

Add -x flag to all pytest commands in _python-tests.yml to stop test
execution immediately after the first failure. This provides faster
feedback in CI when tests fail and reduces unnecessary compute usage.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Co-authored-by: AI

Add -x flag to all pytest commands in _python-tests.yml to stop test
execution immediately after the first failure. This provides faster
feedback in CI when tests fail and reduces unnecessary compute usage.

Co-authored-by: AI
@github-actions
Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Copy Markdown
Contributor

propel-code-bot bot commented Mar 27, 2026

Add pytest -x to CI workflows for faster failure feedback

This PR updates the GitHub Actions workflow .github/workflows/_python-tests.yml to add the pytest exit-on-first-failure flag across all test invocations. The change applies to direct python -m pytest commands and to bin/rust-integration-test.sh calls so that CI stops on the first test failure and reduces unnecessary runtime.

This summary was automatically generated by @propel-code-bot

propel-code-bot[bot]

This comment was marked as outdated.

@rescrv rescrv changed the title ci: add pytest exit-on-first-failure flag to GitHub workflows [ENH] add pytest exit-on-first-failure flag to GitHub workflows Mar 27, 2026
Copy link
Copy Markdown
Contributor

@propel-code-bot propel-code-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review found no issues with the proposed workflow change.

Status: No Issues Found | Risk: Low

Review Details

📁 1 files reviewed | 💬 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant