[CHORE] Upgrade reqwest and spanner crates by rescrv · Pull Request #6705 · chroma-core/chroma

rescrv · 2026-03-20T19:25:19Z

Description of changes

Update the Rust workspace to the newer reqwest and google-cloud-rust
releases, and adjust affected call sites to match the new APIs.

bump reqwest to 0.13 and switch rustls/query features to the
current names
bump google-cloud-rust to v20260319 and populate the new channel
keepalive fields in spanner client configs
pin fastrace crates to compatible versions and update tracing setup
for the current OpenTelemetry SDK builder API
fix test/emulator helpers impacted by upstream API changes,
including tempfile persistence handling
add backoff/retry loops for spanner emulator support to work in CI

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Co-authored-by: AI

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

github-actions · 2026-03-20T19:25:33Z

propel-code-bot · 2026-03-20T19:25:51Z

Upgrade Rust dependencies and align Spanner/reqwest integrations

This PR upgrades Rust workspace dependencies, notably reqwest to 0.13 and google-cloud-rust to v20260319, with corresponding API and configuration updates across Spanner clients, tracing, and CLI download flows. It adds new Spanner channel keepalive settings, introduces an admin RPC timeout constant for long-running DDL operations, and updates emulator/test helpers plus WAL retry handling to cope with aborted transactions in CI.

It also adjusts OpenTelemetry tracer initialization for the latest SDK builder API, pins fastrace crates to compatible versions, and updates tests/fixtures to match new parquet sizes and emulator behaviors. Configuration toggles disable fragment fetch in worker YAML files.

This summary was automatically generated by @propel-code-bot

sanketkedia · 2026-03-25T17:50:49Z

rust/rust-sysdb/src/spanner.rs

-                    ..Default::default()
+                    endpoint: google_cloud_spanner::apiv1::conn_pool::SPANNER.to_string(),
+                    environment: Environment::Emulator(emulator.grpc_endpoint()),
+                    disable_route_to_leader: false,


what are the semantics of this config?

It will create a connection to an emulated spanner. It also doesn't have a .. Default::default(), which I consider a robustness win.

propel-code-bot

Review found no issues with the dependency upgrades and related updates.

Status: No Issues Found | Risk: Low

Review Details

📁 26 files reviewed | 💬 0 comments

blacksmith-sh · 2026-03-25T23:08:01Z

Found 3 test failures on Blacksmith runners:

Failures

Test	View Logs
`chroma-index/spann::types::tests::test_long_running_data_integrity`	View Logs
`chroma-index/` `spann::types::tests::test_long_running_data_integrity_multiple_parallel_runs`	View Logs
`chroma-index::hnsw_reload_repro/deleted_heads_can_abort_a_future_reload`	View Logs

Update the Rust workspace to the newer reqwest and google-cloud-rust releases, and adjust affected call sites to match the new APIs. - bump reqwest to 0.13 and switch rustls/query features to the current names - bump google-cloud-rust to v20260319 and populate the new channel keepalive fields in spanner client configs - pin fastrace crates to compatible versions and update tracing setup for the current OpenTelemetry SDK builder API - fix test/emulator helpers impacted by upstream API changes, including tempfile persistence handling Co-authored-by: AI annotate as bytes rather than [u8] explicit config of new params incompatibility that does not surface on OS X; try it fix(wal3): retry aborted spanner transactions The Spanner emulator only supports one transaction at a time, causing tests to fail with Aborted errors when running in parallel. The publish_fragment method already had an external retry loop, but init and apply_garbage did not. - Add retry-with-backoff loop to ManifestManager::init for Aborted transactions, matching the pattern in publish_fragment - Add retry-with-backoff loop to apply_garbage for Aborted transactions - Add Error::is_aborted() helper to detect Aborted status from both TonicError and SpannerSessionError variants - Update hardcoded parquet fragment sizes in tests (1044 -> 1092) to match new parquet output size from upgraded crate Co-authored-by: AI

claude bot reviewed Mar 20, 2026

View reviewed changes