Disable canvas acceleration in Firefox 110 in test cases#737
Conversation
LeeLenaleee
approved these changes
Mar 6, 2023
Author
|
@kurkle Would you maybe have time to review this? :) |
kurkle
approved these changes
Mar 15, 2023
Author
|
Is the failed test a Windows issue or just a flaky test? My local run works just fine: |
Contributor
|
@SebastiaanSafeguard the issue is a timeout. It happens on GITHUB cloud for Windows. Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) in node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 8059) A collaborator or maintainer should re-execute the test on Windows. |
Author
|
The result is the timeout, that's not the issue itself. There is always a reason for a timeout to happen. |
Member
Windows workers time out randomly but consistently :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See chartjs/Chart.js#11165