Add shear and compression wave velocities to Linear Elastic Material Properties for #692 by cgeudeker · Pull Request #705 · cb-geo/mpm

cgeudeker · 2021-02-10T05:43:38Z

Describe the PR
Add shear and compression wave velocities to linear elastic material properties related to #692 .

Related Issues/PRs
Related to #692, specifically Kelvin-Voigt boundary.

Additional context
The following gives information that can also be found in the following paper. Kelvin-Voigt boundary elements operate as a dashpot, spring system according to the following equations.

Equations for calculating P-wave (c_p) and S-wave (c_s) velocities:

$E^c$ is the constrained modulus, calculated as $E^c = \frac{\sigma_{11}}{\varepsilon_{11}} = \frac{(1 - \nu)E}{(1 + \nu)(1-2\nu)}$

Equations for calculating corresponding spring coefficients:

Additionally, constrained modulus and shear modulus were calculated. layer_thickness was the only value that could not be calculated by the already existent material properties.

Input File Format:

P-wave and S-wave velocities are automatically calculated using values already defined in linear elastic properties. The values are then recorded into the JSON material properties object

    properties_["pwave_velocity"] = vp_;
    properties_["swave_velocity"] = vs_;

codecov · 2021-02-10T06:01:44Z

Codecov Report

Merging #705 (30ef52e) into develop (4c93b20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #705   +/-   ##
========================================
  Coverage    96.78%   96.78%           
========================================
  Files          130      130           
  Lines        25882    25899   +17     
========================================
+ Hits         25048    25065   +17     
  Misses         834      834

Impacted Files	Coverage Δ
include/materials/linear_elastic.h	`100.00% <ø> (ø)`
include/materials/linear_elastic.tcc	`100.00% <100.00%> (ø)`
tests/materials/linear_elastic_test.cc	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27086f7...30ef52e. Read the comment docs.

kks32 · 2021-02-14T13:02:34Z

include/materials/linear_elastic.h

+  //! Layer Thickness
+  double layer_thickness_{std::numeric_limits<double>::max()};
+  //! P Spring Coefficient
+  double p_spring_coeff_{std::numeric_limits<double>::max()};
+  //! S Spring Coefficient
+  double s_spring_coeff_{std::numeric_limits<double>::max()};


Remove all these lines as it is not good to store layer thickness in the material. Should be computed at the nodes.

kks32

In the PR description could you add how the input file would look like for the linear elastic part?

Instead of a separate boolean, maybe the best option would be to:

   "earthquake": {
       "shear_wave_velocity": 300,
       "compression_wave_velocity": 600
    }

cgeudeker · 2021-02-20T22:51:44Z

@kks32 I updated the PR description. In short though, I felt that a boolean parameter worked better since it is just determining whether or not the P-wave and S-wave properties would be calculated. Alternatively though if we want to be able to input them as well, perhaps overwriting the calculation that would have been made otherwise than I think your approach would make more sense.

kks32 · 2021-02-22T22:45:07Z

@cgeudeker The boolean doesn't do anything, you can set it to true and not actually define vs or vp. I don't understand what you mean by Alternatively though if we want to be able to input them as well, perhaps overwriting the calculation that would have been made otherwise than I think your approach would make more sense.? Please add the input file example in the PR description

kks32 · 2021-02-22T23:12:25Z

mpm/tests/materials/norsand_test.cc

Line 70 in c9630b3

REQUIRE(material->template property<double>("density") ==

Reference for how to get a specific material property

kks32 · 2021-02-22T23:09:39Z

include/materials/linear_elastic.tcc

+    // Special material properties
+    if (material_properties.contains("earthquake")) {
+      bool earthquake =
+          material_properties.at("earthquake").template get<bool>();
+
+      if (earthquake) {


Suggested change

// Special material properties

if (material_properties.contains("earthquake")) {

bool earthquake =

material_properties.at("earthquake").template get<bool>();

if (earthquake) {

kks32 · 2021-02-22T23:09:51Z

include/materials/linear_elastic.tcc

+      }
+    }


Suggested change

}

}

…rial

kks32 · 2021-02-25T10:22:52Z

tests/materials/linear_elastic_test.cc

+
+  SECTION("LinearElastic check properties earthquake") {
+    unsigned id = 0;
+    jmaterial["p_wave_velocity"] = 116.023870223;


This is an incorrect text, you can't pass the values of p_wave and s_wave velocity and check if that's correct.

kks32 · 2021-02-25T10:24:38Z

include/materials/linear_elastic.h

+  //! S-Wave Velocity
+  double s_wave_velocity_{std::numeric_limits<double>::max()};
+  //! P-Wave Velocity
+  double p_wave_velocity_{std::numeric_limits<double>::max()};


Suggested change

//! S-Wave Velocity

double s_wave_velocity_{std::numeric_limits<double>::max()};

//! P-Wave Velocity

double p_wave_velocity_{std::numeric_limits<double>::max()};

//! Compressional Wave Velocity

double vp_{std::numeric_limits<double>::max()};

//! Shear wave Velocity

double vs_{std::numeric_limits<double>::max()};

kks32 · 2021-02-25T10:25:07Z

include/materials/linear_elastic.tcc

+    p_wave_velocity_ = sqrt(constrained_modulus / density_);
+    s_wave_velocity_ = sqrt(shear_modulus / density_);


Suggested change

p_wave_velocity_ = sqrt(constrained_modulus / density_);

s_wave_velocity_ = sqrt(shear_modulus / density_);

vp_ = sqrt(constrained_modulus / density_);

vs_ = sqrt(shear_modulus / density_);

include/materials/linear_elastic.tcc

kks32 · 2021-02-25T10:26:40Z

tests/materials/linear_elastic_test.cc

+    jmaterial["p_wave_velocity"] = 116.023870223;
+    jmaterial["s_wave_velocity"] = 62.0173672946;


Suggested change

jmaterial["p_wave_velocity"] = 116.023870223;

jmaterial["s_wave_velocity"] = 62.0173672946;

kks32 · 2021-02-25T10:26:53Z

tests/materials/linear_elastic_test.cc

+    jmaterial["p_wave_velocity"] = 116.023870223;
+    jmaterial["s_wave_velocity"] = 62.0173672946;
+
+    auto material =


Check in 3D too

kks32 · 2021-03-02T21:10:29Z

@jgiven100 Hi Joel if you have some time could you please review this? I'm happy with the changes to calculate shear wave and compression wave velocities in Linear Elastic model

jgiven100

@cgeudeker Thanks for adding vs_ and vp_ to the linear elastic model. This looks great!

@kks right now we don't have linear elastic documentation online (probably since the model only consists of an elastic tensor). Do we want to start a documentation page for linear elastic if we will be adding more features to the model for earthquake MPM?

cgeudeker added 11 commits November 9, 2020 19:30

initiate absorbing constraint

32fdba3

initiate absorbing constraint

2360285

initiate bounding constraint update

10c6415

Test Case Attempt

cee7b4e

Working Test Case

04e38ef

3D test case

7e7ebfc

3D test case, clang-format

7210c21

Earthquake Material Property

e1a3c2e

Earthquake Material Property

917cdbc

Earthquake Material Property

59bcff1

Earthquake Material Properties

d1e42ef

cgeudeker added 2 commits February 10, 2021 10:18

Earthquake Material Properties, test case

dbf0023

Earthquake Material Properties, clang format

3b431c3

kks32 requested changes Feb 14, 2021

View reviewed changes

cgeudeker and others added 2 commits February 19, 2021 19:22

Remove Layer Thickness from material property

b392949

Merge branch 'develop' into material

1187ad0

kks32 self-assigned this Feb 20, 2021

kks32 added Priority: Low Status: In progress Type: Enhancement labels Feb 20, 2021

kks32 requested changes Feb 20, 2021

View reviewed changes

kks32 requested changes Feb 22, 2021

View reviewed changes

cgeudeker added 3 commits February 22, 2021 18:00

Earthquake Boolean Removal and Fixed Test Case

de75919

Earthquake Boolean Removal and Fixed Test Case

8f98064

Merge branch 'material' of https://github.com/cgeudeker/mpm into mate…

2c44bee

…rial

kks32 requested changes Feb 25, 2021

View reviewed changes

Variable renames and 3d Test Case

30ef52e

kks32 approved these changes Mar 2, 2021

View reviewed changes

kks32 requested a review from jgiven100 March 2, 2021 21:09

kks32 changed the title ~~Linear Elastic Material Properties for #692~~ Add shear and compression wave velocities to Linear Elastic Material Properties for #692 Mar 2, 2021

jgiven100 approved these changes Mar 2, 2021

View reviewed changes

cbgeo merged commit 86ba10e into cb-geo:develop Mar 3, 2021

jgiven100 mentioned this pull request Mar 6, 2021

Add linear elastic material model to documentation cb-geo/mpm-doc#60

Merged

cgeudeker mentioned this pull request Mar 24, 2021

Kelvin-Voigt Boundary Implementation for #692 #710

Open

		p_wave_velocity_ = sqrt(constrained_modulus / density_);
		s_wave_velocity_ = sqrt(shear_modulus / density_);

		jmaterial["p_wave_velocity"] = 116.023870223;
		jmaterial["s_wave_velocity"] = 62.0173672946;

Conversation

cgeudeker commented Feb 10, 2021 • edited by kks32 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kks32 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgeudeker commented Feb 20, 2021

Uh oh!

kks32 commented Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kks32 commented Feb 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kks32 commented Mar 2, 2021

Uh oh!

jgiven100 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cgeudeker commented Feb 10, 2021 •

edited by kks32

Loading

codecov bot commented Feb 10, 2021 •

edited

Loading

kks32 left a comment •

edited

Loading

kks32 commented Feb 22, 2021 •

edited

Loading