feat(android): allow custom OkHttpClient via factory#1376
Open
whydidoo wants to merge 2 commits intocallstack:mainfrom
Open
feat(android): allow custom OkHttpClient via factory#1376whydidoo wants to merge 2 commits intocallstack:mainfrom
whydidoo wants to merge 2 commits intocallstack:mainfrom
Conversation
Replace direct OkHttpClient instantiation with a configurablefactory in companion object, enabling custom client configuration(SSL, interceptors, timeouts) from the host application.
|
@whydidoo is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 23fc64d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct OkHttpClient instantiation with a configurablefactory in companion object, enabling custom client configuration(SSL, interceptors, timeouts) from the host application.
Summary
Currently,
RemoteScriptLoadercreates a hardcodedOkHttpClient()instance with no way to customize it. This is a problem for apps that need custom HTTP configuration — for example, certificate pinning, custom SSL trust managers, logging interceptors, or proxy settings.This PR introduces a static
okHttpClientFactorylambda in acompanion object, allowing host applications to provide their ownOkHttpClientinstance before any network requests are made:The client is lazily initialized via by
lazy, so the factory is only called once on the first use.Test plan
okHttpClientFactory, a defaultOkHttpClient()is used (no regression).okHttpClientFactoryinApplication.onCreate()or a React Native module initializer with a custom interceptor, confirm the interceptor is invoked during remote script loading.