fix: codegen didn't run warning on android#91
Merged
okwasniewski merged 1 commit intocallstack:mainfrom Oct 29, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
This fixes a warning that we got when running the library on Android:
(NOBRIDGE) WARN Codegen didn't run for RNCTabView. This will be an error in the future. Make sure you are using @react-native/babel-preset when building your JavaScript code.Looks like React Native now requires the user to transpile their code using the react native babel preset. This PR adds the babel preset to babel config and tells builder bob to use the preset.
This is a temporary fix and we will add this plugin directly to bob in the future.
How to test this?
yarn packNOBRIDGE) WARN Codegen didn't run for RNCTabView. This will be an error in the future. Make sure you are using @react-native/babel-preset when building your JavaScript code.warning.