feat(iOS): Added translucent property for iOS#62
Merged
okwasniewski merged 6 commits intocallstack:mainfrom Oct 20, 2024
Merged
feat(iOS): Added translucent property for iOS#62okwasniewski merged 6 commits intocallstack:mainfrom
okwasniewski merged 6 commits intocallstack:mainfrom
Conversation
Collaborator
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Overall looks good! Thanks for implementing this. Did you try to run it on Android? I think that it needs an empty setter with prop name translucent because without it it might fail
ios/TabViewImpl.swift
Outdated
Comment on lines
163
to
172
| @ViewBuilder | ||
| func tabBarTranslucent(_ translucent: Bool) -> some View { | ||
| self | ||
| .onAppear { | ||
| UITabBar.appearance().isTranslucent = translucent | ||
| } | ||
| .onChange(of: translucent) { newValue in | ||
| UITabBar.appearance().isTranslucent = newValue | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Looks like you are using 4 space indentation while the project is using 2 spaces, can you fix that? We probably need SwiftLint in the repo to catch this
Contributor
Author
There was a problem hiding this comment.
Added an empty setter in android and fixed indentation issues as well.
Thank you for suggestion @okwasniewski. Will keep these in mind in future PRs.
…-native-bottom-tabs into feat/translucent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of this: #11
Summary : This PR adds the support for translucent in iOS.
Adding video for reference:
translucent={false}Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-19.at.20.16.49.mp4
translucent={true}Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-19.at.20.18.27.mp4