fix: add react-navigation export to package.json#44
Merged
okwasniewski merged 1 commit intocallstack:mainfrom Oct 16, 2024
Merged
fix: add react-navigation export to package.json#44okwasniewski merged 1 commit intocallstack:mainfrom
okwasniewski merged 1 commit intocallstack:mainfrom
Conversation
Collaborator
|
Hey, thanks for opening the PR! Do you think this Im not sure if both of them are needed |
Contributor
Author
|
I’m not sure I think that may be for metro or older node - what I’ve typically done is just added a new file like react-native.js at the root that they will use and that file just re-exports things from the right dist folder. I can link to that pattern later when I’m back from dinner. |
okwasniewski
approved these changes
Oct 16, 2024
Collaborator
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for the PR, let's leave the react-navigation/package.json to keep compatibility with older node as you mentioned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yo! Awesome work with this library, was testing it out with onestack.dev and this makes things a bit easier to set up with Vite.