Skip to content

Fix/bottom safe area#37

Merged
okwasniewski merged 5 commits intomainfrom
fix/bottom-safe-area
Oct 14, 2024
Merged

Fix/bottom safe area#37
okwasniewski merged 5 commits intomainfrom
fix/bottom-safe-area

Conversation

@okwasniewski
Copy link
Collaborator

This PR fixes bottom safe area handling by measuring the tab bar on the native side and offsetting it in JS.

CleanShot.2024-10-11.at.12.34.41.mp4

@okwasniewski
Copy link
Collaborator Author

cc @dylancom let me know what you think 👍🏻

@dylancom
Copy link
Contributor

dylancom commented Oct 11, 2024

In order to make the blurring background on the tabbar work style={{ overflow: visible }} needs to be set on the scrollviews. Or do you know a better solution?

Simulator Screenshot - iPhone 16 Pro - 2024-10-11 at 15 51 05

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be moved to ios/ folder. Currently getting an error that TabMeasuredEvent can't be found.

@dylancom
Copy link
Contributor

Great work!

@okwasniewski
Copy link
Collaborator Author

okwasniewski commented Oct 12, 2024

Hey @dylancom I finally figured it out!!

Now its working with the built-in behavior 🚀 Scroll views are automatically inseted.

CleanShot.2024-10-12.at.09.30.12.mp4

@dylancom
Copy link
Contributor

Clever find!!
Awesome.

@dylancom
Copy link
Contributor

Some bugs while testing on my end. The scrollbar starts too late in the top and on reaching the end some content is still below the tabbar.

@okwasniewski okwasniewski merged commit 825e39c into main Oct 14, 2024
@okwasniewski okwasniewski deleted the fix/bottom-safe-area branch October 14, 2024 18:24
@dylancom
Copy link
Contributor

If I test the example app in the latest main the content still ends below the tabbar on my end.

@ferrannp
Copy link

@okwasniewski I just tried this and the issue still persists. Do you have a working example?

@jnsdrssn
Copy link
Contributor

jnsdrssn commented Nov 3, 2024

@ferrannp try contentInsetAdjustmentBehavior="always" on the ScrollView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants