Merged
Conversation
Collaborator
Author
|
cc @dylancom let me know what you think 👍🏻 |
Contributor
dylancom
suggested changes
Oct 11, 2024
TabMeasuredEvent.swift
Outdated
Contributor
There was a problem hiding this comment.
File should be moved to ios/ folder. Currently getting an error that TabMeasuredEvent can't be found.
Contributor
|
Great work! |
104819d to
2c4795d
Compare
Collaborator
Author
|
Hey @dylancom I finally figured it out!! Now its working with the built-in behavior 🚀 Scroll views are automatically inseted. CleanShot.2024-10-12.at.09.30.12.mp4 |
Contributor
|
Clever find!! |
Contributor
15b0895 to
872b36c
Compare
Contributor
|
If I test the example app in the latest main the content still ends below the tabbar on my end. |
|
@okwasniewski I just tried this and the issue still persists. Do you have a working example? |
Contributor
|
@ferrannp try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR fixes bottom safe area handling by measuring the tab bar on the native side and offsetting it in JS.
CleanShot.2024-10-11.at.12.34.41.mp4