fix: replace RN babel preset with codegen plugin directly#181
Merged
okwasniewski merged 4 commits intocallstack:mainfrom Dec 5, 2024
Merged
fix: replace RN babel preset with codegen plugin directly#181okwasniewski merged 4 commits intocallstack:mainfrom
okwasniewski merged 4 commits intocallstack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: a4da8db The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… when building the lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Replaced RN babel preset in the main package with codegen plugin in order to prevent injecting
@babel/runtimeinto the code when building the release version.This was causing issues in setup where
swcis used instead ofbabelsinceswchas it's own helpers (equivalent of@babel/runtime). I believe helpers should be injected when bundling the project and not at the time of building the library, so there is no hard requirement of having@babel/runtimeas a dependency in the project.How to test?
Screenshots
n/a