Skip to content

fix(docs): wrong default value for labeled prop#177

Merged
okwasniewski merged 1 commit intocallstack:mainfrom
Nodonisko:patch-1
Dec 4, 2024
Merged

fix(docs): wrong default value for labeled prop#177
okwasniewski merged 1 commit intocallstack:mainfrom
Nodonisko:patch-1

Conversation

@Nodonisko
Copy link
Contributor

PR Description

Default value is wrong because labels are by default hidden on Android when tab is not focused.

How to test?

Screenshots

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024

⚠️ No Changeset found

Latest commit: cc7f159

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you also update guides/standalone-usage.md?

@Nodonisko
Copy link
Contributor Author

@okwasniewski I actually found out that it's not easy, it's default false on Android, but default true on iOS which makes sense as it is platform default. I tried to reflect this in docs.

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense now! Thanks

@okwasniewski okwasniewski merged commit 4e0fa46 into callstack:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants