Skip to content

Validate usage of features in editions #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhump merged 4 commits into from
Apr 5, 2024
Merged

Validate usage of features in editions #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e9ec5c
restore early check for proto3 and first enum value being zero; add t…
jhump Mar 27, 2024
a4cc631
add feature usage validation and other option validation that protoc …
jhump Mar 27, 2024
1456188
add test cases
jhump Apr 3, 2024
328ecf1
add more checks that protoc performs
jhump Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions internal/tags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ const (
// FileOptionsTag is the tag number of the options element in a file
// descriptor proto.
FileOptionsTag = 8
// FileOptionsJavaStringCheckUTF8Tag is the tag number of the java_string_check_utf8
// field in the FileOptions proto.
FileOptionsJavaStringCheckUTF8Tag = 27
// FileOptionsFeaturesTag is the tag number of the features field in the
// FileOptions proto.
FileOptionsFeaturesTag = 50
Expand Down Expand Up @@ -177,6 +180,21 @@ const (
// FieldOptionsTag is the tag number of the options element in a field
// descriptor proto.
FieldOptionsTag = 8
// FieldOptionsCTypeTag is the number of the ctype field in the
// FieldOptions proto.
FieldOptionsCTypeTag = 1
// FieldOptionsPackedTag is the number of the packed field in the
// FieldOptions proto.
FieldOptionsPackedTag = 2
// FieldOptionsLazyTag is the number of the lazy field in the
// FieldOptions proto.
FieldOptionsLazyTag = 5
// FieldOptionsJSTypeTag is the number of the jstype field in the
// FieldOptions proto.
FieldOptionsJSTypeTag = 6
// FieldOptionsUnverifiedLazyTag is the number of the unverified_lazy
// field in the FieldOptions proto.
FieldOptionsUnverifiedLazyTag = 15
// FieldOptionsFeaturesTag is the tag number of the features field in the
// FieldOptions proto.
FieldOptionsFeaturesTag = 21
Expand Down Expand Up @@ -296,4 +314,23 @@ const (
AnyTypeURLTag = 1
// AnyValueTag is the tag number of the value field of the Any proto.
AnyValueTag = 2

// FeatureSetFieldPresenceTag is the tag number of the field_presence field
// in the FeatureSet proto.
FeatureSetFieldPresenceTag = 1
// FeatureSetEnumTypeTag is the tag number of the enum_type field in the
// FeatureSet proto.
FeatureSetEnumTypeTag = 2
// FeatureSetRepeatedFieldEncodingTag is the tag number of the repeated_field_encoding
// field in the FeatureSet proto.
FeatureSetRepeatedFieldEncodingTag = 3
// FeatureSetUTF8ValidationTag is the tag number of the utf8_validation field
// in the FeatureSet proto.
FeatureSetUTF8ValidationTag = 4
// FeatureSetMessageEncodingTag is the tag number of the message_encoding
// field in the FeatureSet proto.
FeatureSetMessageEncodingTag = 5
// FeatureSetJSONFormatTag is the tag number of the json_format field in
// the FeatureSet proto.
FeatureSetJSONFormatTag = 6
)
Loading