Skip to content

[legacy-framework] Enable proxy support for cli/install#2264

Merged
flybayer merged 3 commits intoblitz-js:canaryfrom
mubaidr:proxy-support
Apr 24, 2021
Merged

[legacy-framework] Enable proxy support for cli/install#2264
flybayer merged 3 commits intoblitz-js:canaryfrom
mubaidr:proxy-support

Conversation

@mubaidr
Copy link

@mubaidr mubaidr commented Apr 23, 2021

Closes: blitz-js/legacy-framework#115

What are the changes and their implications?

More info:
blitz-js/legacy-framework#115

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

@mubaidr
Copy link
Author

mubaidr commented Apr 23, 2021

Documentation update pull request: blitz-js/blitzjs.com#454

@mubaidr mubaidr marked this pull request as ready for review April 23, 2021 17:31
@mubaidr mubaidr requested a review from flybayer as a code owner April 23, 2021 17:31
@flybayer
Copy link
Member

Sweet, thank you!!

@flybayer flybayer merged commit 92f769d into blitz-js:canary Apr 24, 2021
@blitzjs-bot
Copy link
Contributor

Added @mubaidr contributions for code

flybayer added a commit to blitz-js/blitzjs.com that referenced this pull request Apr 27, 2021
Co-authored-by: Brandon Bayer <b@bayer.ws>
ghost pushed a commit to blitz-js/id.blitzjs.com that referenced this pull request Jul 10, 2021
* updated prisma migrate usage in docs (#419)

Co-authored-by: JuanM04 <me@juanm04.com>
Co-authored-by: Andreas Bollig <andreas.bollig@gmail.com>
Co-authored-by: Abu Uzayr <abu.uzayr@builtforfifty.com>
Co-authored-by: François Best <francois@francoisbest.com>
Co-authored-by: Faraz Patankar <farazpatankar@gmail.com>
Co-authored-by: Eric Vicenti <ericvicenti@users.noreply.github.com>
Co-authored-by: Alex <alex@dolo.dev>

* Update docs for upgrade to React Query v3 (#424)

Co-authored-by: JuanM04 <me@juanm04.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Brandon Bayer <b@bayer.ws>
Co-authored-by: Andreas Bollig <andreas.bollig@gmail.com>
Co-authored-by: Abu Uzayr <abu.uzayr@builtforfifty.com>
Co-authored-by: François Best <francois@francoisbest.com>
Co-authored-by: Faraz Patankar <farazpatankar@gmail.com>
Co-authored-by: Eric Vicenti <ericvicenti@users.noreply.github.com>
Co-authored-by: Layne Geck <layne.geck@gmail.com>
Co-authored-by: gstranger <36181416+gstranger@users.noreply.github.com>
Co-authored-by: Andrea Rizzello <10348930+andrearizzello@users.noreply.github.com>

* Document Routes Manifest (#430)

Co-authored-by: Brandon Bayer <b@bayer.ws>
Co-authored-by: Jahred Hope <jahredhope@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>

* Updated dependencies

* Uppercased "admin" in session-management.mdx (#441)

* Few maintainers retire

* Add myself as L1 Maintainer (#443)

* Fix the first two issues of #436 (#439)

* Edit Dieman's personal website (#445)

* update hero code sample to use new Routes object

* new maintainer TommasoBruno added (#444)

* new maintainer TommasoBruno added

* href TommasoBruno maintainer changed

* Added `--inspect` flag to CLI (#447)

Added to `cli-start.mdx` & `cli-dev.mdx`

* Fix minor typo in query-usage.mdx (#449)

* Added a note about broken symlinks

* Typo in contributing.mdx

* Improve deploy-vercel.mdx consistency and clarity (#450)

* Upgraded dependencies

* Remove Anonymous Functions Exports  (#451)

* typo fix

Small typo fix:
you'll need to do the
chech
=>
you'll need to do the
check

* Update session.create > session.$create

* Update api routes doc examples - no anon exports

* Edit preview mode doc examples - no anon exports

* Change export name to handler

* Change export name to handler

* Added BlitzApiHandler

* Update contributing.mdx

* add RIT as sponsor

* Added description to `useInfiniteQuery` and `usePaginatedQuery` (#453)

* update docs for server.ts

* Update get-started.mdx

* Formatted docs

* Updated dependencies

* Fix typo tutorial.mdx (#458)

Typo removed

* Admonitions --> Cards (#456)

* Recommend customTsParser for building a new recipe (#455)

* add info for proxy-support blitz-js/blitz#2264 (#454)

Co-authored-by: Brandon Bayer <b@bayer.ws>

* Documentation for new schema.prisma transform utilities (#457)

Co-authored-by: Brandon Bayer <b@bayer.ws>

* Extend "run postgres via docker" section (#460)

* add multitenancy doc page

* update query and mutation docs to reflect latest recommendations

* add example of creating entity to multitenancy page

* update docs for blitz.config.ts

* update docs for nextjs 10.2

* another update

* Changed Prettier config to match new app config

* Add `scroll-behavior: smooth;` to main.css (#461)

This commit is rather simple. It simply makes the scrolling when you scroll by id much smoother. For example, when you use the Back to top button in the footer, it won't jump up so quickly, it'll instead scroll. This is useful because it will surprise people less and it'll seem cleaner and less choppy too.

* Update use-paginated-query.mdx

* Update use-infinite-query.mdx

* Create guide to deploy to Railway (#462)

Co-authored-by: JuanM04 <me@juanm04.com>

* fix tutorial

* update link

* Update done method in passportjs.mdx (#464)

* Update use-infinite-query.mdx

* Fix typo in tutorial.mdx (#467)

* fix build

* Toggling text and removing outline (#469)

Co-authored-by: Brandon Bayer <b@bayer.ws>

* Update query-usage.mdx

* add docs for setting up node.js

* Documentation about prefetching and dehydratedState (#465)

* improve custom server doc

* Fixes import path for useCurrentUser in authorization.mdx (#471)

* Update session-management.mdx

* Images optimization (#474)

* typo fix

Small typo fix:
you'll need to do the
chech
=>
you'll need to do the
check

* Update session.create > session.$create

* Update api routes doc examples - no anon exports

* Edit preview mode doc examples - no anon exports

* Change export name to handler

* Change export name to handler

* lazy load random contributor images

* lazy load appropriate player, url

* switch to Image tag

* fix image sizing

* change user track image to github url

* make layout intrinsic

Co-authored-by: Roshan Manuel <Roshan,manuel@angelic-group.com>

* redirectAuthenticatedTo with Routes Manifest in authorization.mdx (#475)

* Typo in tradeoffs.mdx (#477)

* Update query-usage.mdx

* Documentation Improvement: Page.authenticate implies Page.suppressFirstRenderFlicker (#476)

* add cookie prefix to docs

* Document authenticate.redirectTo: RouteManifest (#479)

* Add doc page for eslint config and fix typo (#478)

Co-authored-by: Roshan Manuel <Roshan,manuel@angelic-group.com>

* Missing import (#480)

If you try to copy-paste the examples there's a missing import

* Avoid hardcoding "admin" role during impersonation (#481)

When you impersonate another use it would be a good idea to assumer their role too.

Most endpoints will be protected with some for of authorizer e.g. `resolver.authorize("seller")` or `resolver.authorize("buyer")`. 
If you try and invoke these endpoints as an admin, they all need to be changed to `resolver.authorize(["seller", "admin"])` or `resolver.authorize(["buyer", "admin"])` etc.

If you assume the role of the user you're impersonating, you don't need to change anything.

In terms of security: 
- `startImpersonating` should only be available to admins, so it should be secured with `resolver.authorize("admin")`.
- we can allow `stopImpersonating` to be called without a role restriction as it is: the code already checks if `impersonatingFromUserId` is present in the session. If present, the user simply regains whatever role they had before ("admin", "support", etc), otherwise the endpoint is no-op.

* `resolver.authorize` description at resolver-server-utilities.mdx (#484)

* Fix theme toggle (#485)

* Add doc page for prettier config (#482)

Co-authored-by: Roshan Manuel <Roshan,manuel@angelic-group.com>

* Husky doc (#487)

Co-authored-by: Roshan Manuel <Roshan,manuel@angelic-group.com>
Co-authored-by: JuanM04 <me@juanm04.com>
Co-authored-by: Brandon Bayer <b@bayer.ws>

* Fix typo at testing.mdx (#489)

* update docs for nextjs 10.2.3

* Expanded getQueryKey and invalidateQuery at resolver-client-utilities.mdx (#492)

* add some comments to getQueryKey and invalidateQuery

* add link to react query docs

* Add bilaterial reference between dynamic routing and useParam/useRouterQuery (#491)

* Add usecase "dynamic routing"

* Add reference to useParams, useParam and useRouterQuery

* typo, move link at useParams and useParam

* Test database notes (#493)

* add test database to postgres docker docs

* clarified that test db must be different than main

* feat: add documentation for customServer.hotReload (#495)

Co-authored-by: Roshan Manuel <Roshan,manuel@angelic-group.com>
Co-authored-by: JuanM04 <me@juanm04.com>
Co-authored-by: Brandon Bayer <b@bayer.ws>
Co-authored-by: Roshan Manuel <31125563+Roesh@users.noreply.github.com>
Co-authored-by: Francesco Sardo <francesco.deploy@gmail.com>
Co-authored-by: Antony Kamp <tony.kamp@web.de>
Co-authored-by: Nikolay <enemycnt@users.noreply.github.com>
Co-authored-by: Andreas Thomas <dev@chronark.com>
Co-authored-by: Marek Orłowski <16357457+ormarek@users.noreply.github.com>

* Typo in API routes documentation (#496)

* fix build

* update 1.0 expectation date

* adds documentation for utility functions (#498)

Co-authored-by: Brandon Bayer <b@bayer.ws>

* docs: document new setPublicDataForUser API (#500)

Co-authored-by: Brandon Bayer <b@bayer.ws>
Co-authored-by: Lukas Neumann <l.neumann@layer9.berlin>

* adds documentation for utility functions (#498) (#502)

* add docs for RedirectError

* Clarify distinction between useSession & useCurrentUser (#501)

* Update mutation-resolvers.mdx (#503)

* add docs for nextjs 11 (#504)

* add docs for formatZodError

* Upgrade blitz and to react 18 (#505)

* Add instruction for render.yaml (#507)

* Adds builder.printMessage documentation (#508)

Co-authored-by: Nicolas <ntorres.dev@gmail.com>

* Update font-optimization.mdx

* Update prismjs to version 1.24.0 (#510)

* update docs for nextjs 11

* fix build

* Bump ws from 7.4.3 to 7.5.0 (#506)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Alex Dolan <amdolan45@gmail.com>
Co-authored-by: JuanM04 <me@juanm04.com>
Co-authored-by: Andreas Bollig <andreas.bollig@gmail.com>
Co-authored-by: Abu Uzayr <abu.uzayr@builtforfifty.com>
Co-authored-by: François Best <francois@francoisbest.com>
Co-authored-by: Faraz Patankar <farazpatankar@gmail.com>
Co-authored-by: Eric Vicenti <ericvicenti@users.noreply.github.com>
Co-authored-by: Alex <alex@dolo.dev>
Co-authored-by: Brandon Bayer <b@bayer.ws>
Co-authored-by: tundera <tunderadev@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Layne Geck <layne.geck@gmail.com>
Co-authored-by: gstranger <36181416+gstranger@users.noreply.github.com>
Co-authored-by: Andrea Rizzello <10348930+andrearizzello@users.noreply.github.com>
Co-authored-by: Simon Knott <info@simonknott.de>
Co-authored-by: Jahred Hope <jahredhope@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Co-authored-by: Alessandro <alessandro.buonerba@ovoenergy.com>
Co-authored-by: laubonghaudoi <laubonghaudoi@icloud.com>
Co-authored-by: Alessandro <a.buonerba@hotmail.com>
Co-authored-by: Tommaso Bruno <bruno.tommaso31@gmail.com>
Co-authored-by: Antony <info@antonykamp.de>
Co-authored-by: Justin Hall <justin.r.hall@gmail.com>
Co-authored-by: Fatih Altinok <fatihaltinok@live.com>
Co-authored-by: Roshan Manuel <31125563+Roesh@users.noreply.github.com>
Co-authored-by: Antony <tony.kamp@web.de>
Co-authored-by: mlabate <labate.mario@gmail.com>
Co-authored-by: Tom MacWright <tmcw@users.noreply.github.com>
Co-authored-by: Muhammad Ubaid Raza <mubaidr@gmail.com>
Co-authored-by: Jeremy Liberman <jeremy@jeremyliberman.com>
Co-authored-by: DawnOfMidnight <78233879+dawnofmidnight@users.noreply.github.com>
Co-authored-by: Kevin Østerkilde <kevin@oesterkilde.dk>
Co-authored-by: meepdeew <43303008+meepdeew@users.noreply.github.com>
Co-authored-by: Hardik Gaur <hardikgaur3296@gmail.com>
Co-authored-by: craigglennie <craig.glennie@gmail.com>
Co-authored-by: Roshan Manuel <Roshan,manuel@angelic-group.com>
Co-authored-by: swiftgaruda <16741392+swiftgaruda@users.noreply.github.com>
Co-authored-by: Pankaj Patil <pankaj.patil2099@hotmail.com>
Co-authored-by: Francesco Sardo <francesco.deploy@gmail.com>
Co-authored-by: Nikolay <enemycnt@users.noreply.github.com>
Co-authored-by: Andreas Thomas <dev@chronark.com>
Co-authored-by: Marek Orłowski <16357457+ormarek@users.noreply.github.com>
Co-authored-by: Mark Hughes <markwilliamhughes1@gmail.com>
Co-authored-by: garnerp <garnerp@gmail.com>
Co-authored-by: Sean Winner <srwinner16@gmail.com>
Co-authored-by: Lukas Neumann <lksnmnn@gmail.com>
Co-authored-by: Lukas Neumann <l.neumann@layer9.berlin>
Co-authored-by: Dustin Bachrach <ahdustin@gmail.com>
Co-authored-by: Daniel Almaguer <danielalmaguer@gmail.com>
Co-authored-by: Kevin Peters <kevinigeligeligel@gmail.com>
Co-authored-by: Nicolas Torres <nicolas.torres.gussoni@gmail.com>
Co-authored-by: Nicolas <ntorres.dev@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@itsdillon itsdillon changed the title Enable proxy support for cli/install [legacy-framework] Enable proxy support for cli/install Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blitz unable to find/install any recipe when using a proxy

3 participants